Fix optional property types #6872
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* initial add progress bar * add animationIterationCount to theme * add story decorators for static color backgrounds * more style fixes * more value fixes * support classnames in field label * cleanup * cleanup * address review comments * add autodocs * update size jsdoc * fix label position and row gap * use self(height) instead of new variable * improve styles * remove width prop * move text static colors to FieldLabel * use full border radius * various color improvements Co-authored-by: Reid Barber <[email protected]>
* Add pre commit hook for lint
Co-authored-by: Reid Barber <[email protected]>
* add new story with Tag links * style cursor as pointer for links * add Link to empty tag example * remove errorMessage prop * fix isEmphasized text color * remove isRequired prop * update field gap to match other fields * make renderEmptyState font family sans * remove dup key in theme * fix WebkitTapHighlightColor for disabled tag * remove WebkitTapHighlightColor handling * cleanup stories Co-authored-by: Reid Barber <[email protected]>
* renaming to picker and adding initial style macro changes * field and input styles added * two quick style fixes from feedback * removing staticColor, fixing isDisabled, and improving some prop handling * lint spacing fixes * fixing the focusRing after menu close * quiet style as element with rounded ends * undid testing mode * implementing the isQuiet focus ring more closely, but looks less correct * chevron icon cleanup * refining styles based on feedback Co-authored-by: Kyle Taborski <[email protected]>
Co-authored-by: Kyle Taborski <[email protected]>
Co-authored-by: Yihui Liao <[email protected]>
* initialize ref support * add more ref support to components * clean up * more cleanup * update refs * remove dialog inner export, make helptext ref optional, fix ts * more ts fixes Co-authored-by: Yihui Liao <[email protected]>
* Fix disabled, emphasized, selected ToggleButton style * Make it so selected quiet disabled toggle buttons are consistent with the non quiet variant at the moment the designs show that disabled toggle buttons shouldnt have any style differences whether they are selected or not * make forced colors match when selected/not selected and disabled
* Remove styleProps in InlineAlert * create new styleProps with UNSAFE * new file for styleProps Co-authored-by: Yihui Liao <[email protected]>
Workflow icons
Co-authored-by: Yihui Liao <[email protected]>
Co-authored-by: Yihui Liao <[email protected]>
* Popover and Menu
* add isEmphasized to CheckboxGroup * omits isDisabled from DropZone * prioritize checkbox group isEmphasized Co-authored-by: Yihui Liao <[email protected]>
* update illustrated message font size * remove v3 style props * remove unneccessary styling Co-authored-by: Yihui Liao <[email protected]>
* ActionMenu and positioning props for Menu
* feat: add rounded edges and side label to progress bar * only add margin if label exists
* feat: add subtle and outline fill to s2 badge * update comment * add transparent border, fix neutral outline color * fix layout * make props optional
* Fix lint job on CI
* remove --extensions as they are unnecessary add is-mingw use isMinGW to use proper slashes on windows git bash * remove logs from preview builder * is-mingw is a dev dep * patching storybook-builder-parcel to solve windows forward slash issues --------- Co-authored-by: David Coleman <[email protected]> Co-authored-by: Daniel Lu <[email protected]>
* Fix Safari docs crash
alecmev
force-pushed
the
fix-optional-property-types
branch
from
c04c9f6
to
30e77c7
Compare
| @@ -59,7 +59,7 @@ export interface DOMProps { | |||
| /** | |||
| * The element's unique identifier. See [MDN](https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/id). | |||
| */ | |||
| id?: string | |||
| id?: string | undefined | |||
There was a problem hiding this comment.
this looks correct, but is really going to need to exist in so many more places
https://github.com/microsoft/TypeScript/blob/a86b5e2b01075db5046521958a3e0b905b4ca667/tests/lib/react18/react18.d.ts#L1863
Any way we can use the type from the original set instead of creating our own? maybe extends Pick<HTMLElement, 'id'>?
There was a problem hiding this comment.
The focus of this PR is to just fix the public API. I don't see anything wrong with adding | undefined in more places, but that's #1890.
Updated to use extends 😉
There was a problem hiding this comment.
Sure, I guess i'm worried about potential regressions, and I'm also not sure that this is really all there is to fix in the public API, seems like too small a change?
There was a problem hiding this comment.
You're right, there's most likely more, I only submitted the changes necessary to unblock our particular cocktail of Spectrum 😛 I'll create more PRs in the future as I run into other issues.
Hopefully #1890 will be addressed soon, but until then, one option could be to add a quick smoke test, that just lists every single package as a dependency and runs tsc with skipLibCheck: false, strict: true and exactOptionalPropertyTypes: true? This will allow you to make sure that the public API is clean, without switching the whole monorepo to exactOptionalPropertyTypes: true.
* add Well codemod * add migration docs for well * add codemod for badge * update well font * add story for testing style macro * add to migration docs
fixes adobe#6961 Co-authored-by: Homa Wong <[email protected]>
* add maxWidth to examples * dedupe items
alecmev
force-pushed
the
fix-optional-property-types
branch
from
5d21ca7
to
0ad564b
Compare
* update tokens * fix dragged theme * remove deprecated token * remove comment
…obe#6966) * Fixing Tags so they properly truncate if wider than the container * revert story change
feature - Breadcrumb collapse
snowystinger
previously approved these changes
Aug 30, 2024
devongovett
force-pushed
the
main
branch
2 times, most recently
from
a79adcf
to
3013156
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #1890 (comment)
✅ Pull Request Checklist:
📝 Test Instructions:
Install any of
react-spectrumpackages that bring in@internationalized/dateand@react-types/shared, and type-check the project withexactOptionalPropertyTypes: true.hourCyclecauses this:DOMPropscauses this: